Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1783
Overall it looks fine to me now. I am still a bit concerned about guava as
a dependency, but beyond that it seems like a great addition to the bolt.
---
If your project is set up for it, you can
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88964361
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
-
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1745
Looks good overall. Didn't spend a lot of time digging in to all the
details but it looks like a really nice start.
---
If your project is set up for it, you can reply to this email and have your
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1759
@knusbaum if this is merged in could you please close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1767
-1.
InterruptedException we often use to indicate that the process is shutting
down, and we want to not blow up when we see them. Perhaps what we want to do
is to better document
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1768
-1.
InterruptedException we often use to indicate that the process is shutting
down, and we want to not blow up when we see them. Perhaps what we want to do
is to better document
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1769
The changes look good to me. I don't see any issues with it, and the code
is a lot smaller.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1781#discussion_r88945391
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/trident/state/CassandraBackingMap.java
---
@@ -0,0 +1,232
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1781#discussion_r88945322
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/trident/state/CassandraBackingMap.java
---
@@ -0,0 +1,232
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1781#discussion_r88944857
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/executor/AsyncExecutor.java
---
@@ -138,6 +139,109 @@ public void onFailure
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1781#discussion_r88944588
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/executor/AsyncExecutor.java
---
@@ -138,6 +139,109 @@ public void onFailure
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1781#discussion_r8895
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/executor/AsyncExecutor.java
---
@@ -23,16 +23,16 @@
import
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88938511
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
-
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88938308
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
-
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88939110
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
-
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88940442
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
---
@@ -40,51 +48,85 @@
*
*/
public class
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88937595
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
--- End diff --
Could you please revert the spacing back to how it was before
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88938675
--- Diff: external/storm-hbase/pom.xml ---
@@ -1,92 +1,92 @@
-
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88941608
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
---
@@ -40,51 +48,85 @@
*
*/
public class
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r88943466
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
---
@@ -40,51 +48,85 @@
*
*/
public class
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r88932885
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/utils/ArtifactoryConfigLoader.java
---
@@ -0,0 +1,388 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r88935942
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/utils/SchedulerUtils.java ---
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r88932491
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/multitenant/MultitenantScheduler.java
---
@@ -29,19 +29,35 @@
import
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r88936241
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/utils/SchedulerUtils.java ---
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r88934621
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/utils/ArtifactoryConfigLoader.java
---
@@ -0,0 +1,388 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r88936089
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/utils/SchedulerUtils.java ---
@@ -0,0 +1,64 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r88932318
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -2177,13 +2177,37 @@
@isMapEntryType(keyType = String.class, valueType
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r88935380
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/utils/IConfigLoader.java ---
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r88935447
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/utils/IConfigLoader.java ---
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r88931877
--- Diff: storm-core/src/jvm/org/apache/storm/Config.java ---
@@ -2177,13 +2177,37 @@
@isMapEntryType(keyType = String.class, valueType
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r88934834
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/utils/ArtifactoryConfigLoader.java
---
@@ -0,0 +1,388 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1785#discussion_r88933434
--- Diff:
storm-core/src/jvm/org/apache/storm/scheduler/utils/ArtifactoryConfigLoader.java
---
@@ -0,0 +1,388 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1787#discussion_r88930878
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/trident/HdfsState.java
---
@@ -500,6 +500,7 @@ private void updateIndex(long txId
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1789
+1 looks good to me. Although I am not familiar with all of the bolts,
spouts, etc listed here to be sure that the code in the examples is correct.
---
If your project is set up for it, you can
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1786
The test failures look unrelated. They seem to be the same windowing
integration tests failing again.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1786#discussion_r88749944
--- Diff: storm-core/test/clj/org/apache/storm/clojure_test.clj ---
@@ -1,159 +0,0 @@
-;; Licensed to the Apache Software Foundation (ASF) under one
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1786
STORM-1281: LocalCluster, testing4j and testing.clj to java
This is based off of #1744, but I wanted to make sure that my changes were
publicly available.
Now Testing.java replaces
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1744
The test failures look unrelated. It would really be nice if someone could
fix the TumblingWindowTest and SlidingWindowTest. They fail way too often.
---
If your project is set up for it, you can
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1744
I just rebased on top of the latest master (with a java worker translation)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
FYI I put up a separate pull request based off of this one at #1775
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1775
STORM-1278: Port org.apache.storm.daemon.worker to java
This replaces pull request #1756
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1756#discussion_r87902202
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/worker/Worker.java ---
@@ -0,0 +1,426 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
OK I'll get started on this. Should hopefully have something up soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
@abhishekagarwal87 I know you are busy. If you don't have time to do the
rework for this I would be happy to do it for you.
---
If your project is set up for it, you can reply to this email
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r87010659
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -266,19 +266,22 @@ private void
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1679#discussion_r87009044
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -479,16 +487,17 @@ public OffsetAndMetadata
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1765
STORM-2190: reduce contention between submission and scheduling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1764
STORM-2190: reduce contention between submission and scheduling
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1744
Just fixed the merge conflict, and reran the tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1760#discussion_r86603766
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/bolt/RedisFilterBolt.java
---
@@ -45,18 +48,41 @@
*/
public class
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1761
+1 The discussion on STORM-2184 makes since that wakeup seems to not be
needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1721
@aandis thanks for the fix. I merged it into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1721
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1752
Looking at the code #1696 is a much more complete solutions. @knusbaum
could you take a look at it and let us know what you think.
---
If your project is set up for it, you can reply to this email
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1760#discussion_r86378199
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/bolt/RedisFilterBolt.java
---
@@ -45,18 +48,41 @@
*/
public class
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1735
@knusbaum are you OK with the change?
I am +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1755
@erikdw
Thanks, I merged this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1755
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1759
As a note to whoever merges this in we should merge this to 1.0.x too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1758
+1 I see that the race seems to be that if a worker is shut down after
creating the directory, but before running chown on it, then we hit this
situation.
---
If your project is set up for it, you
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1679
@hmcl it has been a week, any hope of finishing the review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
Looks great I am +1 even without the last comment I made (That code can go
away when it is translated to java).
But since I also contributed some of the test code changes I really would
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1756#discussion_r86344854
--- Diff: storm-core/src/clj/org/apache/storm/testing.clj ---
@@ -667,23 +665,18 @@
(.put "spout-emitted" (Atomic
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
Perf numbers look good compared to the 1.x line (very non scientific
though). I didn't dig into it a lot. Running throughput vs latency on my mac
I saw the CPU utilization with this is about half
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1756#discussion_r86233780
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/Task.java ---
@@ -179,22 +178,21 @@ public BuiltinMetrics getBuiltInMetrics
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1756#discussion_r86233431
--- Diff: storm-core/src/clj/org/apache/storm/daemon/local_executor.clj ---
@@ -25,18 +25,3 @@
(let [val (AddressedTuple. task tuple)]
--- End
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
@abhishekagarwal87 I created a pull request to your repo for the failing
tests
https://github.com/abhishekagarwal87/storm/pull/7
I will keep looking at the pull request
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1756#discussion_r86168341
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/worker/Worker.java ---
@@ -0,0 +1,426 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1756#discussion_r86166475
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/worker/Worker.java ---
@@ -0,0 +1,426 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1756#discussion_r86178116
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/worker/LogConfigManager.java ---
@@ -0,0 +1,154 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1750
@HeartSaVioR could you take a look at this and #1749 so I can merge this in?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
@abhishekagarwal87 happy to take a look. I'll see what I can do on the
tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user revans2 reopened a pull request:
https://github.com/apache/storm/pull/1749
STORM-2175: Support at least once shutdown in workers
Will put up a pull request for 1.x shortly.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user revans2 reopened a pull request:
https://github.com/apache/storm/pull/1750
STORM-2175: support at least once shutdown in worker
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2175-1.x
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1750
Will reopen once I have a better fix that gives more time and throws on a
timeout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user revans2 closed the pull request at:
https://github.com/apache/storm/pull/1750
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 closed the pull request at:
https://github.com/apache/storm/pull/1749
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1749
Will reopen once I have a better fix that gives more time and throws on a
timeout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1750
STORM-2175: support at least once shutdown in worker
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2175-1.x
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1749
STORM-2175: Support at least once shutdown in workers
Will put up a pull request for 1.x shortly.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1747
I cherry-piked #1697 back to 1.0.x and then removed the features not
supported in this version of storm.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1747
STORM-2018: Supervisor V2 (1.0.x)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2018-1.0.x
Alternatively you
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1679
@hmcl take your time. This is a critical piece of storm code and I really
would like it right.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1679
I looked through the code and I didn't see anything that concerned me, and
the travis test failure appears to be unrelated so I am +1 pending feedback
form @hmcl
@harshach you also
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1679
@srdo @hmcl have all of your concerns been addressed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1697
@srdo sounds good. I filed
https://issues.apache.org/jira/browse/STORM-2175 to address the race condition.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1697
OK so going through the code in both cases it looks like the only way that
can happen is if the workers is somehow being shut down multiple times. My
guess is that because the slots
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1744
@dossett if you want to build the branch and do some manual testing with
your own topologies especially looking at the UI that would be helpful. I did
it, but only with word count, and I looked
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1697
@HeartSaVioR good catch, I thought I had deleted it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1737
Actually I am consistently getting test failures
{code}
testResumeAbandoned_Text_NoAck(org.apache.storm.hdfs.spout.TestHdfsSpout)
Time elapsed: 5.234 sec <<&
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1737
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1740
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1741
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1726
@HeartSaVioR @redsanket I added in some documentation for this. If you
have time to take another look that would be great.
---
If your project is set up for it, you can reply to this email
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1697
Merged in #1724 now too (it was a trivial cherry pick).
@HeartSaVioR if you want to take a look this should be good for merging in.
Just as an FYI we have been running
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1697
Just pushed the upmerged code. Will look into pulling in #1724 too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1744
STORM-1276: line for line translation of nimbus to java
There are some things I would like to refactor, but this is a function
tested translation that I would like to get it, at least as a starting
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1693
Ok I feel a lot better seeing how you have thought through most of these
things. I would like to see us write out some more examples, not just word
count in what this new API would look like
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1677
+1 please upmerge though. There is a very minor merge conflict. Then ping
me and I'll merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1677
@kamleshbhatt sorry I lost track of this, looking again now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
1301 - 1400 of 3470 matches
Mail list logo
