[GitHub] storm pull request: STORM-817: Support for Kafka Wildcard topics

2015-11-02 Thread sumitchawla
Github user sumitchawla closed the pull request at: https://github.com/apache/storm/pull/561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: STORM-817: Support for Kafka Wildcard topics

2015-11-02 Thread sumitchawla
Github user sumitchawla commented on the pull request: https://github.com/apache/storm/pull/561#issuecomment-153232953 Closing the request as its merged in https://github.com/apache/storm/commit/60d9f81ba1b16f7711c487f831f202e49eda258c --- If your project is set up for it, you can

[GitHub] storm pull request: STORM-817: Support for Kafka Wildcard topics

2015-11-02 Thread sumitchawla
Github user sumitchawla commented on the pull request: https://github.com/apache/storm/pull/561#issuecomment-153157781 Hi @harshach, merge is done and build is passing. Thanks for your review --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: STORM-817: Support for Kafka Wildcard topics

2015-10-27 Thread sumitchawla
Github user sumitchawla commented on the pull request: https://github.com/apache/storm/pull/561#issuecomment-151593590 Done another merge. @ptgoetz @revans2 @HeartSaVioR can you guys please review this change? --- If your project is set up for it, you can reply to this email and

[GitHub] storm pull request: STORM-817: Support for Kafka Wildcard topics

2015-09-26 Thread sumitchawla
Github user sumitchawla commented on a diff in the pull request: https://github.com/apache/storm/pull/561#discussion_r40497455 --- Diff: external/storm-kafka/src/jvm/storm/kafka/DynamicBrokersReader.java --- @@ -40,6 +42,7 @@ private CuratorFramework _curator

[GitHub] storm pull request: STORM-817: Support for Kafka Wildcard topics

2015-07-09 Thread sumitchawla
Github user sumitchawla commented on the pull request: https://github.com/apache/storm/pull/561#issuecomment-120221230 @harshach @Parth-Brahmbhatt .. I have done another upstream merge. I have added some test cases already. Do let me know if you think something is missing --- If

[GitHub] storm pull request: STORM-817: Support for Kafka Wildcard topics

2015-07-09 Thread sumitchawla
Github user sumitchawla commented on the pull request: https://github.com/apache/storm/pull/561#issuecomment-120136074 Any updates on this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] storm pull request: STORM-817: Support for Kafka Wildcard topics

2015-06-29 Thread sumitchawla
Github user sumitchawla commented on the pull request: https://github.com/apache/storm/pull/561#issuecomment-116774534 @harshach change is merged. Build failed for jdk 8 due to an unrelated error. Please review and provide your comments. --- If your project is set up for it, you

[GitHub] storm pull request: STORM-817: Support for Kafka Wildcard topics

2015-05-29 Thread sumitchawla
Github user sumitchawla commented on the pull request: https://github.com/apache/storm/pull/561#issuecomment-106882647 Can anybody please review this PR and provide feedback or comments? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request: STORM-817: Support for Kafka Wildcard topics

2015-05-27 Thread sumitchawla
Github user sumitchawla commented on the pull request: https://github.com/apache/storm/pull/561#issuecomment-106096242 How to use: 1. Add following to your config: config.put("kafka.topic.wildcard.match",true); 2. Pass a wildcard topic to

[GitHub] storm pull request: STORM-817: Support for Kafka Wildcard topics

2015-05-22 Thread sumitchawla
GitHub user sumitchawla opened a pull request: https://github.com/apache/storm/pull/561 STORM-817: Support for Kafka Wildcard topics Support for Wildcard match of topics based on Config - "kafka.topic.wildcard.match". If this config is specified then Topics matching t