[GitHub] storm pull request: STORM-914: AutoHDFS should also update hdfs.co...

2015-07-24 Thread tedxia
Github user tedxia commented on a diff in the pull request: https://github.com/apache/storm/pull/606#discussion_r35410221 --- Diff: external/storm-hdfs/src/test/java/org/apache/storm/hdfs/trident/TridentSequenceTopology.java --- @@ -60,7 +61,7 @@ public static StormTopology

[GitHub] storm pull request: STORM-946: We should remove Closed Client form...

2015-07-17 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/639#issuecomment-122206400 Will you have a look at the description of this pull request, it describe the situation. --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: STORM-946: We should remove Closed Client form...

2015-07-17 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/639#issuecomment-122199889 Yes we should use client.status(), and I am sorry for this error, I will add new patch to fix this. @caofangkun Will you have a look at Client, once client's

[GitHub] storm pull request: STORM-946: We should remove Closed Client form...

2015-07-16 Thread tedxia
GitHub user tedxia opened a pull request: https://github.com/apache/storm/pull/639 STORM-946: We should remove Closed Client form cached-node+port-socket in worker Patch for [STORM-946](https://issues.apache.org/jira/browse/STORM-946) The client may be Closed status after

[GitHub] storm pull request: [STORM-643] KafkaUtils repeat fetch messages w...

2015-07-14 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/405#issuecomment-121188995 In branch 0.10.0, the failed tuple has been managered by ExponentialBackoffMsgRetryManager, should we also make this change to 0.10.0 --- If your project is set up

[GitHub] storm pull request: STORM-910: Submit job failed when submitter us...

2015-06-25 Thread tedxia
GitHub user tedxia opened a pull request: https://github.com/apache/storm/pull/603 STORM-910: Submit job failed when submitter user is also set in nimbu… …s.supervisor.users You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] storm pull request: STORM-903: fix java.lang.ClassNotFoundExceptio...

2015-06-25 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/600#issuecomment-115479671 @revans2 what do you think about add storm-hdfs and storm-hbase and all of their dependencies to extlib-daemon by default. --- If your project is set up for it, you can

[GitHub] storm pull request: [STORM-848] Shade external dependencies

2015-06-25 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/577#issuecomment-115465087 @revans2 thanks for your replay. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: STORM-910: Submit job failed when submitter us...

2015-06-25 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/603#issuecomment-115465234 Thanks for the explain, I will close this patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: STORM-910: Submit job failed when submitter us...

2015-06-25 Thread tedxia
Github user tedxia closed the pull request at: https://github.com/apache/storm/pull/603 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request: STORM-903: fix java.lang.ClassNotFoundExceptio...

2015-06-25 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/600#issuecomment-115479231 @revans2 thanks for your replay. But I still think we must add storm-hdfs and all of its dependencies to lib or extlib, and storm user must add storm-hdfs as topology's

[GitHub] storm pull request: [STORM-848] Shade external dependencies

2015-06-24 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/577#issuecomment-115080809 With this patch, there are a lot of ClassNotFoundException when nimbus or ui load Plugins such as AutoHdfs, what can we do to fix this. --- If your project is set up

[GitHub] storm pull request: STORM-903: fix java.lang.ClassNotFoundExceptio...

2015-06-19 Thread tedxia
GitHub user tedxia opened a pull request: https://github.com/apache/storm/pull/600 STORM-903: fix java.lang.ClassNotFoundException with org.apache.commo… …ns.codec.binary.Base64 when set ui.filter to org.apache.hadoop.security.authentication.server.AuthenticationFilter

[GitHub] storm pull request: STORM-867: fix bug with mk-ssl-connector

2015-06-15 Thread tedxia
GitHub user tedxia opened a pull request: https://github.com/apache/storm/pull/595 STORM-867: fix bug with mk-ssl-connector PR for [STORM-867](https://issues.apache.org/jira/browse/STORM-867) You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] storm pull request: STORM-866: Use storm.log.dir instead of storm....

2015-06-11 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/592#issuecomment-111364440 @HeartSaVioR Thanks for your advice, I just committed another patch. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm pull request: STORM-866: Use storm.log.dir instead of storm....

2015-06-11 Thread tedxia
GitHub user tedxia opened a pull request: https://github.com/apache/storm/pull/592 STORM-866: Use storm.log.dir instead of storm.home in log4j2 config PR for [STORM-866](https://issues.apache.org/jira/browse/STORM-866) The config log4j2 use storm.home as log dir

[GitHub] storm pull request: STORM-858: add java.security.auth.login.confi...

2015-06-09 Thread tedxia
Github user tedxia closed the pull request at: https://github.com/apache/storm/pull/587 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request: STORM-858: add java.security.auth.login.confi...

2015-06-09 Thread tedxia
GitHub user tedxia opened a pull request: https://github.com/apache/storm/pull/587 STORM-858: add java.security.auth.login.config to storm config PR for [STORM-858](https://issues.apache.org/jira/browse/STORM-858) You can merge this pull request into a Git repository by running

[GitHub] storm pull request: STORM-593: remove endpoint-socket-lock for wor...

2015-05-31 Thread tedxia
Github user tedxia closed the pull request at: https://github.com/apache/storm/pull/349 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request: STORM-810: PartitionManager should commit late...

2015-05-22 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/545#issuecomment-104631944 @revans2 will you give me some advice about this PR, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...

2015-05-22 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/540#issuecomment-104631119 @ptgoetz Will you have a look at this, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...

2015-05-03 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/540#issuecomment-98589471 I will try to fix STORM-798 , but how about this patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...

2015-05-03 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/540#issuecomment-98583320 ``` [INFO] [INFO] Reactor Summary: [INFO] [INFO] Storm

[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...

2015-04-29 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/540#issuecomment-97638980 @HeartSaVioR sorry about the failure in test, I had added a new patch to fix this. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm pull request: STORM-806: use storm.zookeeper.connection.time...

2015-04-29 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/540#issuecomment-97647385 ``` 48495 [Thread-229] ERROR backtype.storm.task.ShellBolt - Halting process: ShellBolt died. Command: [ruby, tester_bolt.rb], ProcessInfo pid:7283, name:2 exitCode:-1

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2015-02-04 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-72860304 @miguno I test this on my cluster just now. The topology is more simple spout bolt0 bolt1, and each component only have one executor; I did't met

[GitHub] storm pull request: STORM-613: Fix wrong getOffset return value

2014-12-29 Thread tedxia
GitHub user tedxia opened a pull request: https://github.com/apache/storm/pull/369 STORM-613: Fix wrong getOffset return value When judge getOffset return value, use 0 not NO_OFFSET as invalid offset return value. You can merge this pull request into a Git repository by running

[GitHub] storm pull request: STORM-593: remove endpoint-socket-lock for wor...

2014-12-15 Thread tedxia
GitHub user tedxia opened a pull request: https://github.com/apache/storm/pull/349 STORM-593: remove endpoint-socket-lock for worker-data PR for [STORM-593](https://issues.apache.org/jira/browse/STORM-593) cached-node+port-socket in worker-data is atom, there on need

[GitHub] storm pull request: STORM-593: remove endpoint-socket-lock for wor...

2014-12-15 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/349#issuecomment-66996013 The write lock only protect cached-task-node+port, and not protect cached-node+port-socket. @nathanmarz If we want to ensure send never called on a closed connection

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-12-14 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-66948950 @ptgoetz ,I have merged master branch, and all test success. @clockfly , Will you explain the change to worker.clj, thank you. --- If your project is set up

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-12-10 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-66420678 @clockfly threadpool.schedule() is't a blocking operation, as ``` In particular, because it acts as a fixed-sized pool using corePoolSize threads and an unbounded

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-12-10 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-66422581 I tested this on our cluster, and the result are below: Before remove sleep in connect ![storm](https://cloud.githubusercontent.com/assets/8066671/5373174

[GitHub] storm pull request: STORM-564: Worker use dynamic port

2014-11-24 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/322#issuecomment-64302867 This PR is similar to [STORM-253](https://issues.apache.org/jira/browse/STORM-253), but use different solution, @clockfly can you have a look at this, thank you

[GitHub] storm pull request: STORM-564: Worker use dynamic port

2014-11-20 Thread tedxia
GitHub user tedxia opened a pull request: https://github.com/apache/storm/pull/322 STORM-564: Worker use dynamic port PR for STORM-564 The main change are: 1. Add worker.dynamic.port to indicate whether worker bind dynamic port or not; 2. Add node+port-bind-port

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-11-17 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-63424599 @ptgoetz I have merge storm/master to this patch and all tests pass except storm-core/test/clj/backtype/storm/multilang_test.clj, test results are(after I removed

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-11-17 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-63430061 ``` I tested this by applying it to the 0.9.3 branch and found problems with the unit tests (never-ending cycle of zookeeper reconnects, tests never complete

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-11-11 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-62516293 @clockfly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-11-05 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-61803120 ``` High Availability test test scenario: 4 machine A,B,C,D, 4 worker, 1 worker on each machine test case1(STORM-404): on machine A, kill worker

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-10-09 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-58608389 ok, I will add some specific unit tests later, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-10-09 Thread tedxia
Github user tedxia commented on a diff in the pull request: https://github.com/apache/storm/pull/268#discussion_r18688234 --- Diff: storm-core/src/jvm/backtype/storm/messaging/IConnection.java --- @@ -40,7 +41,7 @@ * @param msgs */ -public void

[GitHub] storm pull request: STORM-329 : buffer message in client and recon...

2014-10-09 Thread tedxia
Github user tedxia commented on the pull request: https://github.com/apache/storm/pull/268#issuecomment-58614296 In this patch, Client have TimeCacheMap for cache new messages that has't been send out. Worker only need add message to corresponding Client, and Client will decide when