[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-15 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1131 @jianbzhou Thanks for filing the JIRA. I have assigned it to me, such that it's easier to keep track and follow up on it. --- If your project is set up for it, you can reply to this email and have you

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-15 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 @hmcl , fired a Jira ticket STORM-2292 and attached the code to the Jira...please let me know if any comments. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-11 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 Thanks erikdw! sorry i was out of office in the last couple of days. I just created a jira account and will create a jira ticket asap and assign to hmcl. --- If your project is set up for it, you

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-06 Thread erikdw
Github user erikdw commented on the issue: https://github.com/apache/storm/pull/1131 @jianbzhou : you can file a STORM JIRA ticket yourself actually -- you just need to [create an Apache JIRA account](https://issues.apache.org/jira/secure/Signup!default.jspa). --- If your project is

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-06 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 @erikdw @hmcl , sorry for the late reply. include only part of my fixes is okie for me, we hope finally the community version has the proper fixes so we can use the community version. I don't ha

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-04 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1131 @jianbzhou thanks for your suggested fix and for the summary of changes. I think that the best way to go about incorporating your changes is to create a JIRA with summary along the lines "Kafka Spout Im

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-04 Thread erikdw
Github user erikdw commented on the issue: https://github.com/apache/storm/pull/1131 > Btw, I just send the latest code to you via email. @jianbzhou: can you please clarify the "you" in this statement? > we have communicated via email for a while and going forward let'

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2017-01-03 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 @hmcl and all, we have communicated via email for a while and going forward let's talk in this thread so everyone is in same page. Base on the spout from the community(written by you), we have s

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2016-08-19 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1131 @jianbzhou you can get obtain at most once semantics by setting maxRetries to zero. Here is the method to do so. https://github.com/apache/storm/blob/master/external/storm-kafka-client/src/main

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2016-08-17 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 @hmcl and all, the new spout is fit for the at least once semantics and works fine for us, thanks a lot! Very recently one of our key customers asked to use a at most once implementation. Do we hav

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2016-06-17 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 @hmcl, just fyi, we found one new issue: when rebalance happened, in method onPartitionsAssigned->initialize(Collection partitions) we can see below two lines: **final OffsetAndMetadata

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2016-06-02 Thread hmcl
Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1131 @jianbzhou thanks. Looking at it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] storm issue #1131: STORM-822: Kafka Spout New Consumer API

2016-06-02 Thread jianbzhou
Github user jianbzhou commented on the issue: https://github.com/apache/storm/pull/1131 @hmcl, today we found one NullpointerException and i applied a fix as below: In method doSeekRetriableTopicPartitions, if one partition was never committed before one message is failed back