Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1359
@ptgoetz @HeartSaVioR
Sorry for the delay. I have a lot of works to do at the end of the year.
Thanks @HeartSaVioR for your help. I fixed this issue and pushed the
commits again. Could
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1359
@vesense
And could you please explain why 738baeb is added? Is there a bug in ported
even scheduler?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1359
@vesense
I've finally fixed the logic to pass the nimbus unit test.
Below is the change commit:
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1359
@ptgoetz
I tried to find why the patch can't pass the tests but no luck. Could you
take a deep look at this?
@revans2
Please take a deep look at this if you have some times to.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1359
@vesense @HeartSaVioR Any update on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1359
@HeartSaVioR Yes, it's still failed. I may need some help in repairing the
unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1359
@vesense
Could you get back to this and address test failure? I think the test is
also failing with last commit.
If you're not sure why the test is failing I'm happy to dig this
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1359
@vesense I guess you may need to fix this issue first, which is what you
found:
```
classname: org.apache.storm.nimbus-test / testname: test-isolated-assignment
expected: (= 1
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1359
@revans2 Do you have time to take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1359
@vesense OK no worries. I just would like to check on this. Please take
your time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1359
@HeartSaVioR Sorry for that. I am too busy to update. I will fix it this
week if I have time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1359
@vesense Do you have any updates on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1359
Oh I missed checking Travis build result. Thanks for noticing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1359
I find travis has some unit test failures in
`org.apache.storm.nimbus-test`. I will spend my time to solve this before
merging in.
---
If your project is set up for it, you can reply to this email
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1359
Thanks @HeartSaVioR . I rebased the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1359
I've done with taking a look, and looks good to me overall.
Since @vesense does quick fix while reviewing, all my review comments are
applied.
+1 from me. Thanks for the great work.
16 matches
Mail list logo
