Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1462
+1 after addressing the minor comment . @roshannaik can you review as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1462
I'm also in favor of using standard java interface. Just it seems not have
any valuable benefits. I'm fine either change or keep it as is.
---
If your project is set up for it, you can reply to
Github user darionyaphet commented on the issue:
https://github.com/apache/storm/pull/1462
I think `FileReader` should same with 'java.io. FileReader' . Implement
`Closeable` interface also have a better extension structure .
---
If your project is set up for it, you can reply to thi
Github user dossett commented on the issue:
https://github.com/apache/storm/pull/1462
Are there any functional changes here? I'm all in favor of using standard
java interfaces, but I don't see any benefits of `closeable` being used here.
Possible changes could include:
- Us
