[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-22 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1477 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1477 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1477 @HeartSaVioR Thanks ~~ I have update commit message to JIRA title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1477 @HeartSaVioR Thanks commit message same with JIRA title maybe better :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1477 You can normally reopen your pull request, but AFAIK, if you delete your branch and push your changes, you can't reopen pull request. --- If your project is set up for it, you can reply to this

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1477 @HeartSaVioR just a miss operation .. btw I couldn't reopen this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1477 @darionyaphet FYI: You don't need to close your pull request. You can `git rebase -i HEAD~1` and modify `pick` to `reword` and save & exit, and modify your commit message for last commit. Af

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1477 @darionyaphet Yes, or `STORM-1895: blobstore replication-factor argument` as title and `replace repl-fctr with replication-factor` as description is also fine for me. --- If your project is set

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread darionyaphet
Github user darionyaphet commented on the issue: https://github.com/apache/storm/pull/1477 @abhishekagarwal87 Should I update commit message to `STORM-1895 : replace repl-fctr with replication-factor` ? --- If your project is set up for it, you can reply to this email and have you

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread satishd
Github user satishd commented on the issue: https://github.com/apache/storm/pull/1477 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #1477: [STORM-1895] Blob Store replication-factor argument

2016-06-09 Thread abhishekagarwal87
Github user abhishekagarwal87 commented on the issue: https://github.com/apache/storm/pull/1477 @darionyaphet can you add jira id in the commit. Looks good otherwise --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your