[GitHub] storm issue #1572: STORM-1976 Remove cleanup-corrupt-topologies! (1.x)

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1572 +1 . build failures are not related to the patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] storm issue #1572: STORM-1976 Remove cleanup-corrupt-topologies! (1.x)

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1572 +1, but I would like to see a tool that can kill a corrupted topology without nimbus being involved, or instructions somewhere on how to do it by logging directly into ZooKeeper. --- If your projec

[GitHub] storm issue #1572: STORM-1976 Remove cleanup-corrupt-topologies! (1.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1572 @revans2 Yes agreed. After removing this code we can't remove corrupted topology in normal way since no nimbus can gain leadership. It would be nice to have a tool to show replication count

[GitHub] storm issue #1572: STORM-1976 Remove cleanup-corrupt-topologies! (1.x)

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1572 @revans2 @HeartSaVioR why can't we enforce the min.replication.count by looking nimbus.seeds if there are more than one host in that list we should set the min.replication.count to 2. User can overr

[GitHub] storm issue #1572: STORM-1976 Remove cleanup-corrupt-topologies! (1.x)

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1572 @HeartSaVioR actually I have thought about it more and I am probably overreacting. If you want to call these blockers it is not that big of a deal. I would just like the community have a follow on

[GitHub] storm issue #1572: STORM-1976 Remove cleanup-corrupt-topologies! (1.x)

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1572 @harshach I don't think that would fix the issue, although it is an improvement. If I think about it more I think what happened was that they were not running with HA/expecting HA to work, but ran i

[GitHub] storm issue #1572: STORM-1976 Remove cleanup-corrupt-topologies! (1.x)

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1572 @HeartSaVioR @revans2 are we ok with merging this in and file a follow-up JIRA to have a discussion around the HA and expectations from user. --- If your project is set up for it, you can reply to

[GitHub] storm issue #1572: STORM-1976 Remove cleanup-corrupt-topologies! (1.x)

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1572 Yes I am good with merging this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #1572: STORM-1976 Remove cleanup-corrupt-topologies! (1.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1572 Yes I think discussion of Nimbus H/A and BlobStore would be longer, so we need to apply short-term fix first. There're lots of critical bugfixes in 1.0.2 so we shouldn't drag the release because

[GitHub] storm issue #1572: STORM-1976 Remove cleanup-corrupt-topologies! (1.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1572 Regarding tool, I filed an issue: https://issues.apache.org/jira/browse/STORM-1985 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.