Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
FYI I put up a separate pull request based off of this one at #1775
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
OK I'll get started on this. Should hopefully have something up soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user abhishekagarwal87 commented on the issue:
https://github.com/apache/storm/pull/1756
I dont mind. Sorry about this. But it will take me sometime before I get
back to the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1756
@abhishekagarwal87 @revans2
I'm even OK that if @revans2 crafts a new PR on top of this, or file an
issue regarding my comments and merge first @abhishekagarwal87 doesn't mind.
---
If your
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
@abhishekagarwal87 I know you are busy. If you don't have time to do the
rework for this I would be happy to do it for you.
---
If your project is set up for it, you can reply to this email and
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
Looks great I am +1 even without the last comment I made (That code can go
away when it is translated to java).
But since I also contributed some of the test code changes I really would
Github user abhishekagarwal87 commented on the issue:
https://github.com/apache/storm/pull/1756
The PR is ready now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user abhishekagarwal87 commented on the issue:
https://github.com/apache/storm/pull/1756
That's good to hear Robert. I will resolve the conflicts and incorporate
your suggestions. Thank you for your help.
---
If your project is set up for it, you can reply to this email and
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
Perf numbers look good compared to the 1.x line (very non scientific
though). I didn't dig into it a lot. Running throughput vs latency on my mac
I saw the CPU utilization with this is about half
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
@abhishekagarwal87 I created a pull request to your repo for the failing
tests
https://github.com/abhishekagarwal87/storm/pull/7
I will keep looking at the pull request
---
If
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1756
@abhishekagarwal87 happy to take a look. I'll see what I can do on the
tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
11 matches
Mail list logo
