Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1781
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
Github user mkoch1 commented on the issue:
https://github.com/apache/storm/pull/1781
Squashed. I don't really see how this should cause any conflicts though.
The only changes in existing code are a couple of namespace corrections (to
avoid wildcard imports, as suggested earlier) and d
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1781
@mkoch1
Could you squash commits into one if you don't mind? I know it's more than
2000 lines change but looks like separating commits are not needed.
And I would like to wait for 1.1.0 R
Github user mkoch1 commented on the issue:
https://github.com/apache/storm/pull/1781
Rebase is done, sorry for the delay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1781
@mkoch1 Could you rebase this? After rebasing I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1781
@mkoch1 Thanks for addressing the license issue. The way you handled the
borrowed code looks fine, the important part is to leave the original copyright
statement, which you did. Thanks for pointing
Github user mkoch1 commented on the issue:
https://github.com/apache/storm/pull/1781
Did not notice that, sorry. Replaced now with an external resource
implementation. The code is not all that complex so it's not a big deal.
One thing I should point out: I borrowed the base i
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1781
Unfortunately this patch uses Cassandra-unit, which is LGPL licensed, so in
it's current state we can't accept it. For that reason I am -1. We've run into
this before, and I've lobbied the Cassandra-
Github user mkoch1 commented on the issue:
https://github.com/apache/storm/pull/1781
That should do it - the batching option has been removed from MapState, in
favor of parallel processing with existing opaque and transactional logic to
handle consistency. Cassandra batch statements a
Github user mkoch1 commented on the issue:
https://github.com/apache/storm/pull/1781
Pls note that mutliPut needs an update - will push commit today or tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
10 matches
Mail list logo
