Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1814
+1 build failure are not relevant (integration test failure)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/1814
@HeartSaVioR Could you please review the revised pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user kamleshbhatt commented on the issue:
https://github.com/apache/storm/pull/1814
Thanks for reviewing the patch @HeartSaVioR .
Modified the pull request as per review comments. Please take a look.
My jira id is "kbhatt".
---
If your project is set up for it, you ca
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1814
@kamleshbhatt Could you let me know your Apache JIRA ID so that I can
assign this issue to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1814
Left some comments but otherwise looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1814
@kamleshbhatt Please remove tick-tuple-test.clj. We don't need both of them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you