[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1868 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1868 @HeartSaVioR I removed the unneeded annotation and rebuilt with JDK7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1868 It was two jdk8 annotations that I didn't remove as part of rework/upmerging. I'll get them --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1868 @revans2 Seems like the commit for JDK 7 is removed so Travis CI shows compile error on JDK 7. Could you address this? --- If your project is set up for it, you can reply to this email and

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/1868 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1868 This branch is also in sync with #1808 now tabs are removed and code is squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1868 @harshach I am happy to once I get a +1 on #1808 too. It has almost identical code, but is for master. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1868 +1. @revans2 can you squash the commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user ppoulosk commented on the issue: https://github.com/apache/storm/pull/1868 Thanks, @revans2. Still +1, NB. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1868 @harshach and @ppoulosk I just pushed fixes for your review comments. @harshach you were right I could and did remove StormStringDeserializer. I think this made the code much better. --- If your

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user ppoulosk commented on the issue: https://github.com/apache/storm/pull/1868 +1, Non-binding. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user harshach commented on the issue: https://github.com/apache/storm/pull/1868 @revans2 overall looks good to me. Minor nits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1868 The test failures are unrelated and are around the integration tests that always seem to fail lately. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm issue #1868: STORM-2225: change spout config to be simpler. (1.x)

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/1868 This is the 1.x version of #1808 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled