[GitHub] storm issue #1891: STORM-2315 Storm kafka client does not commit offsets whe...

2017-01-23 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1891 @liurenjie1024 If I understand correctly this bug happens when user runs topology.num.ackers=0 ? --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] storm issue #1891: STORM-2315 Storm kafka client does not commit offsets whe...

2017-01-23 Thread liurenjie1024
Github user liurenjie1024 commented on the issue: https://github.com/apache/storm/pull/1891 @harshach Yes that's the case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #1891: STORM-2315 Storm kafka client does not commit offsets whe...

2017-01-23 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1891 @liurenjie1024 I am not sure how this code changes will help though. If acking is not enabled adding auto.commit.enable to true on producer properties should solve this right? --- If your project

[GitHub] storm issue #1891: STORM-2315 Storm kafka client does not commit offsets whe...

2017-01-24 Thread liurenjie1024
Github user liurenjie1024 commented on the issue: https://github.com/apache/storm/pull/1891 @harshach Even auto commit is enabled, the acked tuples can not be removed from emitted sets. Here is the calling sequence when ack is disabled: 1. outputCollector.emit(msgId) 1.1 sp

[GitHub] storm issue #1891: STORM-2315 Storm kafka client does not commit offsets whe...

2017-01-31 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/1891 @liurenjie1024 thanks for the details. +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1891: STORM-2315 Storm kafka client does not commit offsets whe...

2017-02-01 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1891 @liurenjie1024 Could you rebase this? STORM-2225 touches many places on storm-kafka-client so you might need to check it's still valid. --- If your project is set up for it, you can reply to thi

[GitHub] storm issue #1891: STORM-2315 Storm kafka client does not commit offsets whe...

2017-04-12 Thread liurenjie1024
Github user liurenjie1024 commented on the issue: https://github.com/apache/storm/pull/1891 @harshach @HeartSaVioR Change rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #1891: STORM-2315 Storm kafka client does not commit offsets whe...

2017-04-13 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1891 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat