Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2002
@liu-zhaokun
Sorry I forgot. Just handled. I added you to the contributor list, so now
you can assign issue to yourself.
---
If your project is set up for it, you can reply to this email
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2002
@HeartSaVioR
Have you merged it to apache storm?Why can't I see the "Assignee" assigned
to me in [issues](https://issues.apache.org/jira/browse/STORM-2410) ?
---
If your project is set up
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2002
Cherry-picked via 4f4c7b4fb8992f879cbbe76cb328c4e13b89b07e
@liu-zhaokun Thanks for contribution. You can close the PR.
---
If your project is set up for it, you can reply to this email
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2002
@HeartSaVioR
Yes,only cherry-picking 6cf2ffb is effective.Would you merge this PR soon?I
will close this PR after merging manually.Thanks for your reply.
---
If your project is set up for
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2002
@liu-zhaokun
Sorry I missed this PR. AFAIK, only cherry-picking `6cf2ffb` will cover
this, right?
You need to close this PR after merging since Github doesn't support auto
close against
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2002
Hello,@HeartSaVioR
Need I create a new PR to clean the commits?But you can merge the PR with
only one file changed,isn't that acceptable?
---
If your project is set up for it, you can
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2002
Hello,@HeartSaVioR
It's not easy to clean up the commits.And there is only one file changed in
the end.Is it necessary to clean up the commits?
---
If your project is set up for it, you
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2002
+1
Please clean up your commits. I think only a commit is sufficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
