Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/2019
@satishd
I have fixed the UTs. The MockCollector.emit used in the UT needed to be
updated to correspond with the emit method used by the JoinBolt. Have
squashed the commits.
---
If your
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2019
+1 for the concept, would like to understand the test failures though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user satishd commented on the issue:
https://github.com/apache/storm/pull/2019
@roshannaik TestJoinBolt is filed with errors in travis runs. Can you take
a look into those failures?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user roshannaik commented on the issue:
https://github.com/apache/storm/pull/2019
Thanks @satishd for the quick turnaround. Updated the PR with the fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user satishd commented on the issue:
https://github.com/apache/storm/pull/2019
+1, LGTM.
@roshannaik You may want to address those minor nits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
