[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client

2017-04-27 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2060 +1 Sorry for the delayed review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client

2017-04-27 Thread knusbaum
Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/2060 Missed the previous request. This all looks good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client

2017-04-27 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2060 @HeartSaVioR @ptgoetz If you have time to take a look I would appreciate it. It looks like @knusbaum might be a bit too busy to take a look in a timely manor. --- If your project is set up for

[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client

2017-04-12 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2060 @knusbaum please take a look at this. There were a number of changes here. Some to replace functionality being used from clojure runtime with java code. Some of it was moving/deduplicating

[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client

2017-04-12 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2060 Now that STORM-2447 is in I have rebased this on master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #2060: STORM-2468: Remove clojure from storm-client

2017-04-11 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2060 Only the last commit is the one to look at. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature