[GitHub] storm issue #2093: STORM-2495:Integrate checkstyle check during build

2017-05-04 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2093 Still +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #2093: STORM-2495:Integrate checkstyle check during build

2017-05-01 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2093 @vinodkc Looks good we are likely going to need to modify the total number of violations when this is ready to be merged in. I would love to see something that can find the

[GitHub] storm issue #2093: STORM-2495:Integrate checkstyle check during build

2017-04-30 Thread vinodkc
Github user vinodkc commented on the issue: https://github.com/apache/storm/pull/2093 @revans2 , I've redirected the warnings to files and added maxAllowedViolations for each project with their current number of violations. Shall add an umbrella JIRA which contains multiple JIRA

[GitHub] storm issue #2093: STORM-2495:Integrate checkstyle check during build

2017-04-28 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2093 @vinodkc We cannot increase the size of the log without paying money to travisci, or switching the build to the internal Jenkins servers at apache. The later has been proposed but is not likely to

[GitHub] storm issue #2093: STORM-2495:Integrate checkstyle check during build

2017-04-28 Thread vinodkc
Github user vinodkc commented on the issue: https://github.com/apache/storm/pull/2093 Due to new checkstyle warnings, size of build log file exceeded 4mb limit. Error from build "The log length has exceeded the limit of 4 MB (this usually means that the test suite is