[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-25 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 @HeartSaVioR That's great. I filed a PR addressing this bug. https://github.com/apache/storm/pull/2239 Could you please review it if you get a chance? Thanks. --- If your project is set up for it,

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-25 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 @Ethanlm Great news for me to figure it out. I just added pair of `username` & `username@domain` while testing so didn't recognize the issue. --- If your project is set up for it, you can reply

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-24 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 @HeartSaVioR Yes. Sure. Should I wait until this PR being merged in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-24 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2204 @Ethanlm since you found this could you file a follow on JIRA to use the PrincipalToLocal plugin in the logviewer when authorizing users? --- If your project is set up for it, you can reply to this

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-24 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 @HeartSaVioR @revans2 I think I figured it out. I added "et...@derekd.ystorm.net" to logs.users and then it works. I traced down to the

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-24 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2204 The change looks good to me and I am +1. Will wait for @Ethanlm to work through his issues first though. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-24 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 Still not authorized.. But I guess it's my problem.. Will try to figure it out. Thanks.

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 @Ethanlm No problem. Thanks for testing my patch thoughtfully. Please let me know if (2) becomes fixed with setting `logs.users` in the topology configuration. --- If your project is set

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-23 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 @HeartSaVioR Thanks! It's good to learn --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 @Ethanlm For now you should include `ethan` to `logs.users` in `topology configuration`. Global configuration doesn't take effect. This behavior seems same as current logviewer. If we

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-23 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 Yea~ It works now. Use nimbus admin account: ![image](https://user-images.githubusercontent.com/14900612/28508825-23b838ee-7003-11e7-81dc-42bd7e23191a.png) Use "ethan" account (it's not

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 @Ethanlm I realized I missed addressing other places for parameter swapped. Just addressed and tested as well. You can just build `storm-webapp` module and copy `storm-webapp jar` into

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 @Ethanlm Yeah I think I addressed (2) and forgot to debug (3). I'll test it quickly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-23 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 Just tested (3). Don't know why (3) is still not working (even with nimbus admin account).

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-23 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 @HeartSaVioR I will test it quickly --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-23 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 @revans2 I fixed the drop down issue, and also fixed issue regarding authorization check. I think it was the reason of issues what @Ethanlm observed. @Ethanlm Could you test it

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-21 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2204 @HeartSaVioR I have not tested on a secure cluster at all. It was all on a single node cluster. I verified that as many links as I could worked correctly. I verified I could switch

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-20 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 @Ethanlm Thanks for the update. I'll try to get it today and put my observation. Btw, my additional commits didn't address anything about bug fix so it doesn't matter which commit you're

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-20 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 @HeartSaVioR An update about _"(2)Got "page not found" while querying worker.log on secure cluster. The file actually exists."_ I probably have setup something wrong. I used

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-20 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 @revans2 Just to check: did you play around secured cluster as well? I still didn't test this on secured cluster, just now set up secured cluster and plan to set up Storm and test. --- If your

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-20 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2204 I did a bunch of testing and I am +1 on merging this in. There is still the issue with double escaping the contents returned for a file, but I think we can fix that after if we want. --- If your

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-20 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2204 Overall it looks good. At least as an accurate translation of the clojure code. I want to play around with it some more, and also try to understand what is happening with some of the escaped

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-19 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2204 I was playing around with it and I am seeing `` in the output log. i.e. ``` 2017-07-19 15:00:49.413 o.a.s.d.s.Slot SLOT_6701 [INFO] STATE EMPTY msInState: 38110 -

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-18 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 1. I believe I tested it from binary distribution. I used "mvn clean install" to compile and "cd storm-dist/binary && mvn package" to created the binary distribution. And then I deployed it under

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-18 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 @Ethanlm > 1. "Prev" "First" etc buttons seems to mix together. (On non-secure and secure cluster) Looks like failing to load css and also js file. We don't include static resource

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-18 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2204 I did some simple tests manually in non-secure and secure storm cluster. It seems that it works well on non-secure storm cluster except some display issues. I found some issues on secure storm

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-16 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 Addressed RAT and checkstyle violation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] storm issue #2204: STORM-1280 port backtype.storm.daemon.logviewer to java

2017-07-14 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2204 Test is failing with RAT issue. ``` [WARNING] Files with unapproved licenses: storm-webapp/src/test/resources/test-3072.log.test