Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2250
Thanks, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2250
Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2250
Added the missing html tags and a title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/2250
+1
Minor nit: It generates html, but not an html *document* (i.e. missing
head, body, etc. tags), but that's just a few print statements that can be
added at merge time.
---
If your projec
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2250
+1. Let's squash the commits and it's good to go as far as I am concerned.
Thanks @srdo
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2250
Addressed comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2250
+1 again, and waiting for @ptgoetz opinion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2250
I think this is good to go. @ptgoetz would this script work for you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
