[GitHub] storm issue #2268: STORM-2689: Simplify dependency configuration for storm-k...

2017-08-20 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2268 @srdo Please squash the commits into one. I'll merge after that. Thanks in advance! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] storm issue #2268: STORM-2689: Simplify dependency configuration for storm-k...

2017-08-20 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2268 +1 Nice improvement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm issue #2268: STORM-2689: Simplify dependency configuration for storm-k...

2017-08-19 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2268 @HeartSaVioR Done. I've changed the storm-kafka(-client)-examples projects to just put some random strings in Kafka and retrieve and print them in the Trident examples. --- If your project is set up

[GitHub] storm issue #2268: STORM-2689: Simplify dependency configuration for storm-k...

2017-08-18 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2268 @srdo +1 to remove DRPC demo in other examples rather than storm-starter. Please go ahead. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm issue #2268: STORM-2689: Simplify dependency configuration for storm-k...

2017-08-11 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2268 We could get rid of the storm-starter dependency if we removed the DRPC demonstration from the Trident examples and replaced the RandomSentenceSpout. There's already a DRPC demo in storm-starter, so I

[GitHub] storm issue #2268: STORM-2689: Simplify dependency configuration for storm-k...

2017-08-11 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2268 @HeartSaVioR You're right, it's nicer if the example is not relying on storm-kafka. I copied the missing classes to storm-kafka-client-examples, and added a bunch of documentation. --- If your

[GitHub] storm issue #2268: STORM-2689: Simplify dependency configuration for storm-k...

2017-08-09 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2268 I feel that dependencies are going to be tricky in storm-kafka-examples and storm-kafka-client-examples. storm-kafka-client-examples depends on storm-kafka-examples, and storm-kafka-examples

[GitHub] storm issue #2268: STORM-2689: Simplify dependency configuration for storm-k...

2017-08-08 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2268 ping @HeartSaVioR and @hmcl since you reviewed https://github.com/apache/storm/pull/2243 and this is related. --- If your project is set up for it, you can reply to this email and have your reply