[GitHub] storm issue #2294: STORM-2517 add interface for Writer, make AbstractHDFSWri...

2017-08-28 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2294 @Angus-Slalom actually because these are all just white space changes I can do it myself when I check it in. Let me run the tests all the way through to be sure it looks good then I'll pull

[GitHub] storm issue #2294: STORM-2517 add interface for Writer, make AbstractHDFSWri...

2017-08-28 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2294 ``` external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/Writer.java 18: 'package' should be separated from previous statement. 23: Wrong lexicographical order for 'java.io.

[GitHub] storm issue #2294: STORM-2517 add interface for Writer, make AbstractHDFSWri...

2017-08-28 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2294 @Angus-Slalom there are some checkstyle violations here, which is why the build is failing. Other then that it looks good. +1 --- If your project is set up for it, you can reply to this email and

[GitHub] storm issue #2294: STORM-2517 add interface for Writer, make AbstractHDFSWri...

2017-08-24 Thread Angus-Slalom
Github user Angus-Slalom commented on the issue: https://github.com/apache/storm/pull/2294 Created for pull request https://github.com/apache/storm/pull/2157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project