Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2365
You are also going to need to fix the checkstyle errors.
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@revans2
I have fix the checkstyle errors and log the exception.Could you help me
review this PR again?
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2365
Actually I have dug deeper, and I think we want to do this differently,
although it will be just as simple of a change.
Currently a ConnectException is thrown deep down that end up being wrap
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
In the long term, it's difficult for us to improve drpc. But would you like
to help merge this PR?
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2365
@liu-zhaokun I'm not sure you understood my comment from before. This
current code has a bug in it. If a DRPC server is down when the spout comes
up, even temporarily down, it will never try and co
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@revans2
I try to fix this bug follow your advice,but I found the original bug
occurred in line 41
[https://github.com/liu-zhaokun/storm/blob/d92f1a9c8d7442d4959fec57813fc5de42b179a9/storm-c
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2365
@liu-zhaokun You are correct I had forgotten the ThriftClient establishes
the connection then initializes the _protocol member and then finally the
Client itself is created which will read from the p
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@revans2
Do you mean there no need to reconnect when I create a DRPCInvocationClient
instance?
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2365
Currently ThriftClient will connect to the server itself in the
constructor. What we want to do is to optionally not do that, and instead let
the DRPCInvocationsClient do it in a location where it c
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
Hi,@revans2,I'm not sure whether the ci's failure related to me.And I have
add a retry to DRPCInvaction,could you help me to review it?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@HeartSaVioR
Hi,are you available to help me review this PR?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@HeartSaVioR @revans2
Hi,are you available to help me review this PR?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
Hi,@revans2,I'm not sure whether the ci's failure related to me.And I have
add a retry to DRPCInvaction,could you help me to review it?
---
Github user liu-zhaokun commented on the issue:
https://github.com/apache/storm/pull/2365
@revans2
Hi,revans! I guess you forgot this PR after a long time.I just want to
know if this PR is available because I used to work hard to make it. Even if
you think it is not good enough,
14 matches
Mail list logo
