Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2387
@hmcl
Thanks, I merged into master.
Like STORM-2781 (#2380) we need another PR on 1.x branch. Please raise pull
requests against 1.x branch. Thanks in advance.
---
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/2387
@srdo @HeartSaVioR I have incorporated the code review changes of the
depending patch. It should be good to merge. Thanks.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2387
Looks like 1.1.x branch also needs the patch, and that branch shouldn't be
on top of STORM-2781.
https://github.com/apache/storm/blob/1.1.x-branch/external/storm-kafka-client/src/main/java/or
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2387
+1 for the change. It might be good to add a test that demonstrates the fix
as well if possible.
---
