[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-04 Thread dujiashu
Github user dujiashu commented on the issue: https://github.com/apache/storm/pull/2492 @srdo Thanks for you help. https://issues.apache.org/jira/browse/STORM-2883 ---

[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-10 Thread dujiashu
Github user dujiashu commented on the issue: https://github.com/apache/storm/pull/2492 When tridentAPI, although set config.usestarttimeifoffsetoutofrange true, it would throw offsetoutofrange exception yet. This issue fix this bug. ---

[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-10 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2492 This breaks the semantics of transactional spouts. Please see http://storm.apache.org/releases/1.1.1/Trident-spouts.html and the sections about transactional and opaque spouts here http://storm.apache.

[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-10 Thread dujiashu
Github user dujiashu commented on the issue: https://github.com/apache/storm/pull/2492 @srdo Thanks so much. I always think opaquespout is only used to resolve kafka disk broken when not set replication ---

[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-11 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2492 @dujiashu Happy to help. If you agree that we shouldn't make this change, would you mind closing this PR? Thanks. ---

[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-11 Thread dujiashu
Github user dujiashu commented on the issue: https://github.com/apache/storm/pull/2492 @srdo Sure, this PR should be closed. ---

[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-12 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2492 @dujiashu I meant could you close it on your end? I think only the author can close PRs at this time. ---

[GitHub] storm issue #2492: [STORM-2883] Fix storm-kafka trident API bug

2018-01-14 Thread dujiashu
Github user dujiashu commented on the issue: https://github.com/apache/storm/pull/2492 @srdo OK. This my first use the github with make PR. I understatnd it now. ---