[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2518 +1 ---

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user hustfxj commented on the issue: https://github.com/apache/storm/pull/2518 +1 Thank you for @vesense ---

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user vesense commented on the issue: https://github.com/apache/storm/pull/2518 Also rebased PR. ---

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user vesense commented on the issue: https://github.com/apache/storm/pull/2518 @hustfxj Added logs and fixed warnings for RocketMqSpout/RocketMqBolt. ---

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user vongosling commented on the issue: https://github.com/apache/storm/pull/2518 Good Catch, what's the plan for this pr? I noticed that we have kept the unmerged status for a long time. ---

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user vesense commented on the issue: https://github.com/apache/storm/pull/2518 @vongosling Added unit tests and rebased PR. ---

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user vongosling commented on the issue: https://github.com/apache/storm/pull/2518 glad to see the update of this pr :-) ---

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user vesense commented on the issue: https://github.com/apache/storm/pull/2518 @vongosling Will add more unit tests later. ---

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2518 @vongosling I'm aware of RocketMQ, just meant that we have unmanaged modules nowadays in Storm repo. since many of us are focusing core, and some of us are making Kafka connector possible to

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user vongosling commented on the issue: https://github.com/apache/storm/pull/2518 @HeartSaVioR RocketMQ is another high performance messaging and low latency engine in Apache, I am glad to introduce it to your storm guys :-) ---

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2518 I'm sad to say this is the case, same case as storm-eventhub which lacks committer sponsors. I can't (and I shouldn't) review connector which I have completely no idea what it is and how it works

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user vesense commented on the issue: https://github.com/apache/storm/pull/2518 Any comments are welcome.. ---

[GitHub] storm issue #2518: STORM-2902: Some improvements for storm-rocketmq module

Github user vesense commented on the issue: https://github.com/apache/storm/pull/2518 @harshach @vongosling @hustfxj Do yo have time to take a look? ---