Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2587
+1
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2587
Thanks for the review. Squashed the commits
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2587
Thanks, I'll go ahead and merge this.
I was wondering if you remember why the try-catch in PacemakerClient.send
was added, which made rotateClient redundant? It's from this PR
https://github.co
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2587
Thanks @Ethanlm, merged to master.
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2587
Thanks for the link. I was new to storm project at that time and I was just
pushing our existing internal code to community. Didn't understand very much
about it at that time.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2587
Okay, thanks. I'm a little uncomfortable swallowing exceptions if we don't
know why. Ping @revans2 and @HeartSaVioR. Do either of you guys recall why
catching and swallowing inside the PacemakerClient.s
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2587
@srdo
I guess @revans2 and @knusbaum could explain the reason, since `internal`
means Oath's own.
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2587
@srdo @HeartSaVioR
@revans2 is on vacation. I will ask him after he is back.
---
Github user Ethanlm commented on the issue:
https://github.com/apache/storm/pull/2587
@srdo Thanks for pointing it out. Eating all the exceptions might not be a
good way and I want to revisit the code and refactor it. Filed a jira
https://issues.apache.org/jira/browse/STORM-3017
--
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2587
@Ethanlm Sounds good, thanks.
---
10 matches
Mail list logo
