[GitHub] storm issue #2608: [STORM-3012] Fix the issue that nimbus will crash if pace...

2018-03-30 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2608 @revans2 Filed a jira https://issues.apache.org/jira/browse/STORM-3017 ---

[GitHub] storm issue #2608: [STORM-3012] Fix the issue that nimbus will crash if pace...

2018-03-27 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2608 @agresch This change makes sure that the responses won't contain any `null` HBMessage. So I think this should be fine. ---

[GitHub] storm issue #2608: [STORM-3012] Fix the issue that nimbus will crash if pace...

2018-03-27 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2608 Seems ok to me. I might also add handling null to PaceMakerStateStorage.java#L195. ---