Github user raghavgautam commented on the issue:
https://github.com/apache/storm/pull/2643
@HeartSaVioR Please look at this pull request
https://github.com/apache/storm/pull/2660
---
Github user ghajos commented on the issue:
https://github.com/apache/storm/pull/2643
@HeartSaVioR @raghavgautam @arunmahadevan Thank you for the review!
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2643
Anyway +1 again.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2643
I don't feel it is mandatory to add a test since it is a known option. I'll
merge this shortly since no one add new review comments so far.
@raghavgautam Could you please submit a patch
Github user raghavgautam commented on the issue:
https://github.com/apache/storm/pull/2643
@ghajos We can bind to the port then close the port and then bind to the
same port again. We have unit tests that can be used as a starting point.
Github user ghajos commented on the issue:
https://github.com/apache/storm/pull/2643
@raghavgautam I think it is out of scope to test a tcp testing in Storm. Do
you have an idea how to do that?
---
Github user raghavgautam commented on the issue:
https://github.com/apache/storm/pull/2643
Can you please add a test for this ?
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2643
+1
---
Github user raghavgautam commented on the issue:
https://github.com/apache/storm/pull/2643
ð
---
Github user ghajos commented on the issue:
https://github.com/apache/storm/pull/2643
@HeartSaVioR Can you please take a look at?
---
10 matches
Mail list logo
