[GitHub] storm issue #2677: STORM-3075 fix NPE

2018-05-17 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2677 @Ethanlm - done. Added a spelling fix. ---

[GitHub] storm issue #2677: STORM-3075 fix NPE

2018-05-17 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2677 @agresch you can squash the commits and then I can merge it in. ---

[GitHub] storm issue #2677: STORM-3075 fix NPE

2018-05-15 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2677 @Ethanlm - please take a look. Thanks. ---

[GitHub] storm issue #2677: STORM-3075 fix NPE

2018-05-15 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2677 @Ethanlm - nice catch. Will fix the source of the problem instead ---

[GitHub] storm issue #2677: STORM-3075 fix NPE

2018-05-15 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2677 There might be a bug in the code: https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java#L490-L497 ``` if (leaderElector ==

[GitHub] storm issue #2677: STORM-3075 fix NPE

2018-05-15 Thread agresch
Github user agresch commented on the issue: https://github.com/apache/storm/pull/2677 @Ethanlm - I see tc being null whenever I start nimbus (at least with no topologies). ---

[GitHub] storm issue #2677: STORM-3075 fix NPE

2018-05-15 Thread Ethanlm
Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2677 It looks reasonable. But would like to understand more about it. Could you elaborate on in which case tc will be null? ---