Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2691
@HeartSaVioR I updated the docs from you comments. Thanks for the review.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2691
+1, Looks good.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2691
@HeartSaVioR @arunmahadevan
I rebased my changes on master, I also ran the example topologies. I had to
make a minor change around the HBase config to make the trident example work.
I
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2691
I am planning right now to get STORM-2882 in first, and then I will come
back and do as much manual testing as possible for the different components,
and update thing accordingly.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2691
@revans2 Do you still plan to do manual tests on this patch? Sadly I
couldn't do it myself for now, so would like to rely on your test result.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2691
Yes that was the plan. there is a lot that depends on storm-autocreds and
I would like to understand it all better before I try to clean it up.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2691
Actually I was wrong. storm-hdfs, storm-hbase, storm-hive seem to depend on
storm-autocreds. I guess we could pull out the required classes into some
common package as part of the follow up
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2691
Sure we can revisit this in a follow up JIRA.
We may not have to split the autocreds since none of the other components
depends on it. The hbase-server dependency if included is just
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2691
@arunmahadevan I am happy to try and split up autocreds to make that
happen, but it is a much larger job than what is currently for this. If you
are fine with waiting I would rather file a follow
