Github user ManoharVanam commented on the issue:
https://github.com/apache/storm/pull/2703
@HeartSaVioR done.
---
Github user ManoharVanam commented on the issue:
https://github.com/apache/storm/pull/2703
Yes , here we are handling two things,
1. Fail fast without uploading the jar
2. Giving clear message to the user at the client side.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2703
+1, it seems fine to me to duplicate the check for convenience
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2703
I agree it would be great to keep all of the clients in sync, but the java
is the only high level client that we support. The only other client we
generate the code for is a python client, but it
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2703
@revans2
You are right, i just thought if we can keep all these clients sync in
rule, but fail fast just for this is ok.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2703
@danny0405 This is just a performance/usability optimization. The checks
are still happening on the server side, so the other clients will still get an
exception when they try to upload a jar, just
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2703
Sorry i don't think put the validation at Client side is a good idea, cause
many kind of clients may interact with Master through thrift RPC, we must keep
all the clients sync on this validation
