Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@revans2
Hi, Bobby, do you have time to review this patch now, cause it's a little
long time and i kind of forget details about this patch, thx in advance.
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@revans2 @HeartSaVioR
Hi, can you help to review this patch now, just a kindly reminder.
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@HeartSaVioR I have already attach the test data in the comment, also a
test class everyone can have a test.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2723
I'd like to say it doesn't mean I don't plan to review this. I'd rather say
other issues which are directly coupled with releases (mostly Storm 2.0.0)
should be reviewed prior to this, unless you
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2723
@danny0405
Could you address @revans2 comment, mostly backing up your proposed patch
with numbers? You may want to get help to correctly measure numbers from
well-known library like JMH.
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@revans2 @HeartSaVioR
Can you help me to review this again ? thx very much
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@revans2
Hi, bobby, i have already updated the test data for this patch.
As for NeedsFullTopologiesScheduler, i agree to remove it. We can tweak the
IsolationScheduler or cache topolog
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2723
@danny0405 I have spent some time looking at your patch, I have not found
any issues with the code itself, but I easily could have missed something. My
biggest problems is that I just cannot get pas
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2723
@danny0405
Remaining tasks would be mostly reviewing existing PRs. I'll sort out and
add them to the epic issue for Storm 2.0.0.
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@HeartSaVioR
Really thx, BTW, i can help to fix if there some bugs left for releasing
STORM-2.0.0.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2723
@danny0405
I'm sorry but now I feel I need to have time to focus on current milestone
- Storm 2.0.0 - and for Storm 2.0.0, this is a kind of improvement and
non-blocker.
There're some is
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2723
@danny0405 Unfortunately I also can't run a large cluster. I could run
Storm in 3~4 VM nodes but I think the patch will not address such small
cluster. I'll take a look at design difference and c
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@HeartSaVioR
Sorry, i have left my company and do not maintain large storm cluster now,
i can only test the numbers on my laptop, i will make a diagram this weekend.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2723
@danny0405
Providing some numbers would help persuading others if it is easy to
measure. If it is not easy to get the numbers, I'm OK to skip and compare the
difference of diagram/code.
--
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@revans2
I draw a img to describe what the work flow was before this pat
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2723
@danny0405 There is a lot of code here and I am trying to understand what
exactly this is doing, because it is hard to get it from just the code. I can
see the extra caching that you put in for the
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@revans2 @HeartSaVioR
Hi, Bobby, HeartSaVioR, please help me to review this if you have time, thx
in advance.
---
Github user danny0405 commented on the issue:
https://github.com/apache/storm/pull/2723
@HeartSaVioR @revans2
Please help me to review this if you have time, thx in advance
---
18 matches
Mail list logo
