Github user choojoyq commented on the issue:
https://github.com/apache/storm/pull/2726
@srdo i think so, thanks for the review
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2726
Is this ready to merge @choojoyq?
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2726
The changes look good to me, +1. Left some comments, but I don't think it
makes sense to put too much effort into making the tests more realistic, or
refactoring, given that storm-kafka is being removed
Github user choojoyq commented on the issue:
https://github.com/apache/storm/pull/2726
@HeartSaVioR
Hi, do you probably know release date of the next storm version where this
pull request potentially will be merged? We are facing this issue pretty often
in our cluster which requi
Github user choojoyq commented on the issue:
https://github.com/apache/storm/pull/2726
@HeartSaVioR Sure, thanks.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2726
@choojoyq Let us port back first if it is OK to be merged.
---
Github user choojoyq commented on the issue:
https://github.com/apache/storm/pull/2726
@HeartSaVioR
Thanks for the fast reply. I pointed this pull request to 1.x-branch.
Does it make sense to open one more pull request for 1.0.x-branch as well?
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2726
@choojoyq
First of all, thanks for your contribution. We are deprecating storm-kafka
from 1.x version and plan to remove this entirely in 2.0 (there're couple of
pull requests to be reviewed
