[GitHub] storm issue #2840: STORM-3147: Add metrics based on ClusterSummary

2018-09-19 Thread revans2
Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2840 I worked with @zd-project fairly closely to come up with the goals for the metrics. I just think we can do better on some of the metrics, but it is not something we have to do right now. I am +1

[GitHub] storm issue #2840: STORM-3147: Add metrics based on ClusterSummary

2018-09-18 Thread srdo
Github user srdo commented on the issue: https://github.com/apache/storm/pull/2840 I'm hoping @zd-project will help review this, since this is a rebase of his PR. I don't really have the context to know whether these added metrics are useful. ---