[GitHub] storm issue #728: [STORM-1038] Upgraded netty to 4.x

2016-09-07 Thread hsun-cnnxty
Github user hsun-cnnxty commented on the issue: https://github.com/apache/storm/pull/728 @kishorvpatil that's an interesting idea. You mean a feature flag to toggle between 3.x and 4.x? I will investigate the possibility. Btw, I have moved the work to #1591. -thanks

[GitHub] storm issue #728: [STORM-1038] Upgraded netty to 4.x

2016-09-06 Thread kishorvpatil
Github user kishorvpatil commented on the issue: https://github.com/apache/storm/pull/728 @hsun-cnnxty, I think this is great change to have. Any way we can implement this as a plugin for us to switch between current implementation? It took substantial amount to get the current versio

[GitHub] storm issue #728: [STORM-1038] Upgraded netty to 4.x

2016-07-30 Thread hsun-cnnxty
Github user hsun-cnnxty commented on the issue: https://github.com/apache/storm/pull/728 @HeartSaVioR @harshach I posted performance test results on #1591. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] storm issue #728: [STORM-1038] Upgraded netty to 4.x

2016-07-25 Thread hsun-cnnxty
Github user hsun-cnnxty commented on the issue: https://github.com/apache/storm/pull/728 As this PR is for master, new PR #1591 is created for 1.x-branch. Performance tests to be done soon. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] storm issue #728: [STORM-1038] Upgraded netty to 4.x

2016-07-10 Thread hsun-cnnxty
Github user hsun-cnnxty commented on the issue: https://github.com/apache/storm/pull/728 Sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] storm issue #728: [STORM-1038] Upgraded netty to 4.x

2016-07-10 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/728 After rebasing, could you do the performance test against 1.x branch? The status of master branch is a WIP so we would be more convenient with 1.x branch. --- If your project is set up for it,

[GitHub] storm issue #728: [STORM-1038] Upgraded netty to 4.x

2016-07-10 Thread hsun-cnnxty
Github user hsun-cnnxty commented on the issue: https://github.com/apache/storm/pull/728 I am currently on vacation and will be back in two weeks. Will work on it as soon as I am back home. -thanks --- If your project is set up for it, you can reply to this email and have y

[GitHub] storm issue #728: [STORM-1038] Upgraded netty to 4.x

2016-07-10 Thread harshach
Github user harshach commented on the issue: https://github.com/apache/storm/pull/728 @hsun-cnnxty we would like to get this into 1.x-branch as well as master. Did you get a chance to look at @revans2 comment above . It will be great if you can address the comment and up merge your pa