Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/743
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/743#issuecomment-154546742
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/743#issuecomment-154545489
I just upmerged and ran the tests on this manually. Everything looks good
for me. I am +1 on merging this in @zhuoliu @harshach @HeartSaVioR do either of
you have any mo
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/743#issuecomment-154461421
Hi @vesense The DisruptorQueue test bug has been fixed in another JIRA.
Could you upmerge and trigger the CI again? This pull request looks good to me,
I am +1 to merge i
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/743#discussion_r43970097
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/trident/TridentKafkaState.java ---
@@ -83,8 +81,8 @@ public void updateState(List tuples,
TridentCollector
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/743#issuecomment-153884995
Thanks @harshach for the explanation! That makes good sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/743#discussion_r43946675
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/trident/TridentKafkaState.java ---
@@ -83,8 +81,8 @@ public void updateState(List tuples,
TridentCollector
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/743#issuecomment-153882896
@zhuoliu for trident we are sending the tuples as a batch and we would like
to know if any of those tuples failed or any other errors occurred rather than
wait for the c
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/743#discussion_r43939104
--- Diff:
external/storm-kafka/src/test/storm/kafka/TridentKafkaTopology.java ---
@@ -88,11 +88,11 @@ public static void main(String[] args) throws Exception
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/743#issuecomment-152083005
@harshach Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/743#discussion_r43349321
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/trident/TridentKafkaState.java ---
@@ -72,27 +73,27 @@ public void prepare(Map stormConf) {
Map
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/743#discussion_r43349319
--- Diff:
external/storm-kafka/src/test/storm/kafka/TridentKafkaTopology.java ---
@@ -88,11 +88,11 @@ public static void main(String[] args) throws Exception
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/743#discussion_r41099133
--- Diff:
external/storm-kafka/src/jvm/storm/kafka/trident/TridentKafkaState.java ---
@@ -72,27 +73,27 @@ public void prepare(Map stormConf) {
Ma
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/743#discussion_r41099035
--- Diff:
external/storm-kafka/src/test/storm/kafka/TridentKafkaTopology.java ---
@@ -88,11 +88,11 @@ public static void main(String[] args) throws Exception
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/743#issuecomment-141853555
@HeartSaVioR Can you please review this. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/743
[STORM-1052] TridentKafkaState uses new Kafka Producer API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm patch-6
Alternatively y
16 matches
Mail list logo
