[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...

2015-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/744 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...

2015-09-30 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/744#issuecomment-144543208 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...

2015-09-30 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/744#issuecomment-144542259 Looks good to me. The only nit is the title of this JIRA: new Kafka Producer API rather than kafka-client. the new Kafka Clients API is still in the process in STORM-

[GitHub] storm pull request: [STORM-1053] Correct storm-kafka readme file b...

2015-09-18 Thread vesense
GitHub user vesense opened a pull request: https://github.com/apache/storm/pull/744 [STORM-1053] Correct storm-kafka readme file because of using new kafka-clients api correct readme file: new producer link & configs You can merge this pull request into a Git repository by running: