[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

GitHub user hustfxj reopened a pull request: https://github.com/apache/storm/pull/ [STORM-1243] port HealthCheck to java You can merge this pull request into a Git repository by running: $ git pull https://github.com/hustfxj/storm health Alternatively you can review and a

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user hustfxj closed the pull request at: https://github.com/apache/storm/pull/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/#issuecomment-186005385 @longdafeng @revans2 @ppoulosk thank you for your review! I have addressed all your comments. --- If your project is set up for it, you can reply to this email and hav

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/#issuecomment-185849836 +1. The code needs to be upmerged, but it is a minor issue in supervisor.clj --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user longdafeng commented on the pull request: https://github.com/apache/storm/pull/#issuecomment-185633860 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user ppoulosk commented on the pull request: https://github.com/apache/storm/pull/#issuecomment-185411289 +1, NB --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/#issuecomment-184968903 @revans2 Thank you --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/#issuecomment-184714383 +1 the translation looks really good. I found one minor issue with the original code, and a few very minor style issues. --- If your project is set up for it, you can

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/#discussion_r53020251 --- Diff: storm-core/src/jvm/org/apache/storm/command/HealthCheck.java --- @@ -0,0 +1,124 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/#discussion_r53019913 --- Diff: storm-core/src/jvm/org/apache/storm/command/HealthCheck.java --- @@ -0,0 +1,124 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/#discussion_r53019635 --- Diff: storm-core/src/jvm/org/apache/storm/command/HealthCheck.java --- @@ -0,0 +1,124 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/#discussion_r53018855 --- Diff: storm-core/src/jvm/org/apache/storm/command/HealthCheck.java --- @@ -0,0 +1,124 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

GitHub user hustfxj reopened a pull request: https://github.com/apache/storm/pull/ [STORM-1243] port HealthCheck to java You can merge this pull request into a Git repository by running: $ git pull https://github.com/hustfxj/storm health Alternatively you can review and a

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

Github user hustfxj closed the pull request at: https://github.com/apache/storm/pull/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] storm pull request: [STORM-1243] port HealthCheck to java

GitHub user hustfxj opened a pull request: https://github.com/apache/storm/pull/ [STORM-1243] port HealthCheck to java You can merge this pull request into a Git repository by running: $ git pull https://github.com/hustfxj/storm health Alternatively you can review and app