Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/1150#issuecomment-195876805
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user wuchong commented on the pull request:
https://github.com/apache/storm/pull/1150#issuecomment-192798074
@revans2addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1150#issuecomment-192307424
Just one minor comment. I am +1 even without the update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r55037499
--- Diff:
storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software Fou
Github user wuchong commented on the pull request:
https://github.com/apache/storm/pull/1150#issuecomment-192233525
@revans2 can you have a look ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1150#issuecomment-189151184
Thanks @wuchong Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Github user wuchong commented on the pull request:
https://github.com/apache/storm/pull/1150#issuecomment-189127326
@abhishekagarwal87 Thanks for your hint.
I have moved `test-clojure-serialization` back to *serialization-test.clj*,
and squashed the commits.
---
If your p
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r54206381
--- Diff:
storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java ---
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache So
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r54198829
--- Diff:
storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java ---
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software Fou
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r54081673
--- Diff:
storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java ---
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache So
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r54081671
--- Diff:
storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java ---
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software Fou
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r54081320
--- Diff:
storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java ---
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache So
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r54078281
--- Diff:
storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java ---
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r54078236
--- Diff:
storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java ---
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r54077825
--- Diff:
storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java ---
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r54077570
--- Diff: storm-core/test/jvm/org/apache/storm/TestConfigValidate.java ---
@@ -18,6 +18,8 @@
package org.apache.storm;
+import com.goog
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r54077452
--- Diff: storm-core/test/jvm/org/apache/storm/TestConfigValidate.java ---
@@ -18,6 +18,8 @@
package org.apache.storm;
+import com.goog
GitHub user wuchong opened a pull request:
https://github.com/apache/storm/pull/1150
[STORM-1250]: port backtype.storm.serialization-test to java
1. Move `validate-kryo-conf-basic` and `validate-kryo-conf-fail` to
`TestConfigValidate.java`
2. I'm not sure wether to translate `te
19 matches
Mail list logo
