Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r54170194
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -134,14 +136,16 @@
(defn logviewer-link [host fname secure?]
(if (and secure
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r54165835
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -134,14 +136,16 @@
(defn logviewer-link [host fname secure?]
(if (and secure
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1139#issuecomment-188850969
@wuchong I am still seeing it even after #1119 was merged in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
Github user wuchong commented on the pull request:
https://github.com/apache/storm/pull/1139#issuecomment-188546255
@revans2 It's a bug which has been fixed in #1119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1139#issuecomment-188543700
+1. It looks fairly good. Thank you @wuchong
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1139#issuecomment-188311189
+1 looks good. I am still seeing some issues with
```
java.lang.ClassCastException: java.lang.Integer cannot be cast to
java.lang.String
at org.apa
Github user wuchong commented on the pull request:
https://github.com/apache/storm/pull/1139#issuecomment-188174878
@revans2 @abhishekagarwal87 @hustfxj Thanks for your review, I have
addressed all the comments.
Can you have a look again?
---
If your project is set up fo
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r53916420
--- Diff: storm-core/src/clj/org/apache/storm/ui/helpers.clj ---
@@ -46,197 +46,3 @@
(fn [req]
--- End diff --
I prefer to leave it here, s
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1139#issuecomment-187946863
A lot of this looks good, But it needs a little bit of work to move the
clojure/ring/hiccup specific parts where they need to be.
---
If your project is set up for it,
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r53863268
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -0,0 +1,319 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r53862671
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -0,0 +1,319 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r53862294
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -0,0 +1,319 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r53861999
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -0,0 +1,319 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r53861576
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -0,0 +1,319 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r53861204
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -0,0 +1,319 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r53860859
--- Diff: storm-core/src/clj/org/apache/storm/ui/helpers.clj ---
@@ -46,197 +46,3 @@
(fn [req]
--- End diff --
Should we move this someplac
Github user wuchong commented on the pull request:
https://github.com/apache/storm/pull/1139#issuecomment-187520534
@abhishekagarwal87 @hustfxj Thanks for your suggestion, I have addressed
all your comments. And fix the commits.
Let me know if you find anything else.
---
If
Github user hustfxj commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r53723573
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -0,0 +1,301 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under o
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1139#issuecomment-187463920
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled an
Github user abhishekagarwal87 commented on the pull request:
https://github.com/apache/storm/pull/1139#issuecomment-187216836
Thanks @wuchong . My comments
Let's just completely do away with clojure classes in UIHelpers. I have
given an example in inline comments.
commits sho
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r53633738
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -0,0 +1,301 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r53633418
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -0,0 +1,301 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1139#discussion_r53630982
--- Diff: storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java ---
@@ -0,0 +1,301 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
GitHub user wuchong opened a pull request:
https://github.com/apache/storm/pull/1139
[STORM-1254]: port ui.helper to java
port ui.helper to java
1. I find that `defelem table` is never be called, so I removed it.
2. I haven't translated `defn requests-middleware`, as
25 matches
Mail list logo
