Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1023
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1023#issuecomment-173345862
@ptgoetz sounds good just running a sanity check with the tests before
merging it in.
---
If your project is set up for it, you can reply to this email and have your
re
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1023#issuecomment-173345063
@revans2 I'll take care of the merge to 0.10.x as soon as this is in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1023#issuecomment-173343533
Because the files have change locations porting to 0.10.x is going to need
a separate pull request (git is not happy)
I will merge this in for master and 1.x-bra
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1023#issuecomment-173310578
+1
I wouldn't mind seeing this go back to 1.x and 0.10.x (0.10.x has a few
other minor fixes). But I don't think we need to support 0.9.x too much longer.
---
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1023#issuecomment-173287607
@vesense I don't see any indication in the JIRA which branches you want
this fix merged into. master and 1.x seem simple enough, but it appears to be
a bug in 10.x and
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1023#issuecomment-172883855
OK so Math.abs(Integer.MIN_VALUE) actually returns Integer.MIN_VALUE
because of an integer overflow error. That is a good corner case to remember
in the future.
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/1023#issuecomment-172426904
why not `Math.abs(val.hashCode() % numPartitions)` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1023#issuecomment-172423672
+1.
The fix is necessary due to follows, which can cause problem during
grouping.
Integer.MAX_VALUE % 1 = 0
Integer.MAX_VALUE % 2 = 0
Integer.MAX_VALUE %
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1023
[STORM-1481] avoid Math.abs(Integer) get a negative value
https://issues.apache.org/jira/browse/STORM-1481
You can merge this pull request into a Git repository by running:
$ git pull https://g
10 matches
Mail list logo
