Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/1028#issuecomment-175899060
Closing this PR as changes are backported to 1.x-branch from master.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user kishorvpatil closed the pull request at:
https://github.com/apache/storm/pull/1028
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1028#issuecomment-174077171
@kishorvpatil I cherry-picked #1027 to the 1.x-branch and it was
clean/trivial so I think you can just close this pull request.
---
If your project is set up for it, y
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1027
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1027#issuecomment-173362346
Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1027#issuecomment-173359428
Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/1027#discussion_r50315408
--- Diff: storm-core/src/jvm/org/apache/storm/messaging/netty/Login.java ---
@@ -0,0 +1,411 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1027#discussion_r50314937
--- Diff: storm-core/src/jvm/org/apache/storm/messaging/netty/Login.java ---
@@ -0,0 +1,411 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/1027#discussion_r50314307
--- Diff: storm-core/src/jvm/org/apache/storm/messaging/netty/Login.java ---
@@ -0,0 +1,411 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/1027#issuecomment-173344407
One very minor nit.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1027#discussion_r50310048
--- Diff: storm-core/src/jvm/org/apache/storm/messaging/netty/Login.java ---
@@ -0,0 +1,411 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1028#issuecomment-173263458
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1027#issuecomment-173263339
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/1027#issuecomment-173018694
@revans2 I reverted the name to `Login`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1027#issuecomment-173014223
I just have the one minor comment about the name of the class that we
pulled over from Zookeeper.
+1 even with the name being a bit confusing to me.
---
If you
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1027#discussion_r50189054
--- Diff:
storm-core/src/jvm/org/apache/storm/messaging/netty/KerberosSaslNettyClient.java
---
@@ -84,7 +83,7 @@ public KerberosSaslNettyClient(Map storm_con
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/1028
[STORM-1485] DRPC Connectivity Issues for 1.-x-branch
- ZK-Login-From-AutoTGT thread should not die if TGT in `AutoTGT` has
expired. ( It gives grace 10 minutes before killing worker.) This req
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/1027
[STORM-1485] DRPC Connectivity Issues
- ZK-Login-From-AutoTGT thread should not die if TGT in `AutoTGT` has
expired. ( It gives grace 10 minutes before killing worker.) This required
copying a
18 matches
Mail list logo
