Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1110#issuecomment-186244285
@hustfxj I was not able to reproduce the failure, so I am not sure what
happened. The changes look good and all of the tests pass for me so I am +1
---
If your project
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1110#issuecomment-186233442
@hustfxj integration.org.apache.storm.integration-test failed, but there is
no indication in the XML file why it failed. I'll try to take a look.
---
If your project i
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1110#issuecomment-186128339
@revans2 why can't the test pass at jdk8 ? can you check it for me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1110#issuecomment-186015740
@revans2 It is nice to file a JIRA to replace this with an
ExecutorService. I am nice to follow up the JIRA.
---
If your project is set up for it, you can reply to th
Github user hustfxj commented on a diff in the pull request:
https://github.com/apache/storm/pull/1110#discussion_r53414672
--- Diff: storm-core/src/jvm/org/apache/storm/event/EventManager.java ---
@@ -0,0 +1,26 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1110#issuecomment-185853831
Just one minor request, but I am +1 either way. It would also be nice to
file a JIRA to replace this with an ExecutorService. It is probably too
complex to do that her
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1110#discussion_r53359219
--- Diff: storm-core/src/jvm/org/apache/storm/event/EventManager.java ---
@@ -0,0 +1,26 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
Github user longdafeng commented on the pull request:
https://github.com/apache/storm/pull/1110#issuecomment-185631768
+1, looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user ppoulosk commented on the pull request:
https://github.com/apache/storm/pull/1110#issuecomment-185425571
Very good translation. +1, NB
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user hustfxj reopened a pull request:
https://github.com/apache/storm/pull/1110
[STORM-1553] port event.clj to java
IRunnableCallback can be used many times to be assue interfaces of
clojure are invoked by java. For example, we can make use of it when translate
time.clj
Github user hustfxj closed the pull request at:
https://github.com/apache/storm/pull/1110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1110#issuecomment-185016434
why do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user hustfxj closed the pull request at:
https://github.com/apache/storm/pull/1110
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
GitHub user hustfxj reopened a pull request:
https://github.com/apache/storm/pull/1110
[STORM-1553] port event.clj to java
IRunnableCallback can be used many times to be assue interfaces of
clojure are invoked by java. For example, we can make use of it when translate
time.clj
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1110#issuecomment-184994638
@abhishekagarwal87 thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user hustfxj commented on a diff in the pull request:
https://github.com/apache/storm/pull/1110#discussion_r52984823
--- Diff: storm-core/src/jvm/org/apache/storm/event/EventManagerImp.java ---
@@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user hustfxj commented on a diff in the pull request:
https://github.com/apache/storm/pull/1110#discussion_r52984812
--- Diff:
storm-core/src/jvm/org/apache/storm/callback/IRunnableCallback.java ---
@@ -0,0 +1,22 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1110#discussion_r52979722
--- Diff: storm-core/src/jvm/org/apache/storm/event/EventManagerImp.java ---
@@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Found
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1110#discussion_r52979444
--- Diff: storm-core/src/jvm/org/apache/storm/event/EventManagerImp.java ---
@@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Found
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1110#discussion_r52979401
--- Diff: storm-core/src/jvm/org/apache/storm/event/EventManagerImp.java ---
@@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Found
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1110#discussion_r52979325
--- Diff: storm-core/src/jvm/org/apache/storm/event/EventManagerImp.java ---
@@ -0,0 +1,102 @@
+/**
+ * Licensed to the Apache Software Found
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1110#discussion_r52979185
--- Diff:
storm-core/src/jvm/org/apache/storm/callback/IRunnableCallback.java ---
@@ -0,0 +1,22 @@
+/**
+ * Licensed to the Apache Software
23 matches
Mail list logo
