Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1142#discussion_r53965439
--- Diff: storm-core/src/jvm/org/apache/storm/command/CLI.java ---
@@ -238,10 +238,13 @@ public CLIBuilder arg(String name, Parse parse, Assoc
assoc) {
Github user wuchong commented on the pull request:
https://github.com/apache/storm/pull/1142#issuecomment-188100054
+1 except a minor comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/storm/pull/1142#discussion_r53898826
--- Diff: storm-core/src/jvm/org/apache/storm/command/CLI.java ---
@@ -238,10 +238,13 @@ public CLIBuilder arg(String name, Parse parse, Assoc
assoc) {
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1142#issuecomment-187738243
+1 I guess I never did test without a -w option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user hustfxj opened a pull request:
https://github.com/apache/storm/pull/1142
[STORM-1572] throw NPE when parsing the command line arguments by CLI
$ storm kill test
Running: /data/nfs_share/soft/jdk1.7.0_79/bin/java -client -Ddaemon.name=
-Dstorm.options= -Dstorm.home=/d