[GitHub] storm pull request: [STORM-1636] - Supervisor shutdown with worker...

2016-03-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request: [STORM-1636] - Supervisor shutdown with worker...

2016-03-22 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1226#issuecomment-199959156 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-1636] - Supervisor shutdown with worker...

2016-03-20 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/1226#issuecomment-198013271 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: [STORM-1636] - Supervisor shutdown with worker...

2016-03-19 Thread hustfxj
Github user hustfxj commented on the pull request: https://github.com/apache/storm/pull/1226#issuecomment-197706290 nice catch. I have considered this when I port supervisor.clj to java. Than you @jerrypeng --- If your project is set up for it, you can reply to this email and have

[GitHub] storm pull request: [STORM-1636] - Supervisor shutdown with worker...

2016-03-19 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/1226#issuecomment-197700574 Also needs to be pushed back into 1.x branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm pull request: [STORM-1636] - Supervisor shutdown with worker...

2016-03-19 Thread jerrypeng
GitHub user jerrypeng opened a pull request: https://github.com/apache/storm/pull/1226 [STORM-1636] - Supervisor shutdown with worker id pass in being nil In function kill-existing-workers-with-change-in-components in supervisor.clj: The function tries to detect whether there