Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/504#issuecomment-108107062
@revans2 @ptgoetz Thanks for reviewing. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/504
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/504#issuecomment-107978418
+1 the changes look good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/504#issuecomment-107750135
I'm +1, but with the understanding that I have not done any testing beyond
unit tests. I would like to see additional Committer reviews before merging.
---
If your proje
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/504#issuecomment-107735366
Restricting fields: https://issues.apache.org/jira/browse/STORM-844
Javadoc: https://issues.apache.org/jira/browse/STORM-843
---
If your project is set up for it
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/504#issuecomment-107725417
@revans2
Thanks for your careful review! I addressed all of your comments.
I have been using private / protected field and public getter/setter unless
it
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/504#discussion_r31473429
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/Options.java
---
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apach
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/504#discussion_r31472716
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/AbstractRedisMapState.java
---
@@ -0,0 +1,87 @@
+/**
+ * License
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/504#discussion_r31471680
--- Diff: external/storm-redis/README.md ---
@@ -194,6 +195,11 @@ RedisState
fields,
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/504#issuecomment-107631879
In general it looks good. I would like to see the docs updated to match
the test code, and I would like to understand why options.keyFactory is not
public.
I
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/504#discussion_r31444080
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/Options.java
---
@@ -0,0 +1,33 @@
+/**
+ * Licensed to the Apache So
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/504#discussion_r31443064
--- Diff:
external/storm-redis/src/main/java/org/apache/storm/redis/trident/state/AbstractRedisMapState.java
---
@@ -0,0 +1,87 @@
+/**
+ * Licensed to
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/504#discussion_r31442963
--- Diff: external/storm-redis/README.md ---
@@ -205,7 +211,8 @@ RedisClusterState
}
JedisClusterConfig clusterConfig = new
JedisClus
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/504#discussion_r31442993
--- Diff: external/storm-redis/README.md ---
@@ -194,6 +195,11 @@ RedisState
fields,
n
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/504#discussion_r31442886
--- Diff: external/storm-redis/README.md ---
@@ -184,7 +184,8 @@ RedisState
JedisPoolConfig poolConfig = new JedisPoolConfig.Builder()
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/504#discussion_r31442926
--- Diff: external/storm-redis/README.md ---
@@ -205,7 +211,8 @@ RedisClusterState
}
JedisClusterConfig clusterConfig = new
JedisClus
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/504#issuecomment-107044730
For convenience, I posted new PR (#567) which applies #504 into
0.10.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/504#issuecomment-107042566
Upmerged.
@revans2 Could you take a look? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/504#issuecomment-89748586
Also applied https://github.com/apache/storm/pull/462 for
RedisClusterMapState.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/504
[STORM-753] Improve RedisStateQuerier to convert List from Redis
value
Please see https://issues.apache.org/jira/browse/STORM-753 for more details.
Applied some refactoring to reduce cod
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/503#issuecomment-89710830
I added a commit to branch, but PR is not reflected.
I'll try to post new PR.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user HeartSaVioR closed the pull request at:
https://github.com/apache/storm/pull/503
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
22 matches
Mail list logo
