[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-31 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/838#issuecomment-152785729 @knusbaum Seems like wrong issue is associated. STORM-885 would be proper. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559947 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -375,7 +394,7 @@ private void waitForPendingMessagesToBeSent() { lo

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559957 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -386,11 +405,10 @@ private void waitForPendingMessagesToBeSent() {

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559976 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -510,8 +546,7 @@ public void operationComplete(ChannelFuture future) throws Exc

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559942 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -335,7 +354,7 @@ public void operationComplete(ChannelFuture future) throws Exc

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559969 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -495,7 +531,7 @@ public void operationComplete(ChannelFuture future) throws Exc

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559934 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -292,7 +311,7 @@ private void dropMessages(Iterator msgs) { // We c

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559884 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -202,7 +217,7 @@ public Status status() { @Override public Ite

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559892 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -266,7 +281,7 @@ public void send(Iterator msgs) { // We can re

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559925 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -281,6 +296,10 @@ private Channel getConnectedChannel() { }

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
GitHub user knusbaum opened a pull request: https://github.com/apache/storm/pull/838 [STORM-855] Heartbeat Server (Pacemaker) This pull request redirects worker heartbeats away from Zookeeper and into a new server, 'Pacemaker'. The redirection is accomplished by making `Clu