GitHub user d2r opened a pull request:
https://github.com/apache/storm/pull/585
[STORM-856] use serialized value of delay secs for topo actions
* Use serialized values for delay in rebalance and kill topology actions,
in case nimbus has initialized sometime after the action was give
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/585#issuecomment-110191747
This should also be merged to 0.10.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/585#issuecomment-110255155
LGTM. Seems like it was a small mistake.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/585#issuecomment-110435396
+1 Thanks for the quick turnaround on this @d2r.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/585#issuecomment-110447694
+1 Works for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/585#issuecomment-110450393
+1, this bug was introduced by me when I worked on rolling upgrade support,
sorry for not catching this during my testing.
---
If your project is set up for it,
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/585#issuecomment-110497517
@d2r I plan to merge this once the 24-hour review period has completed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/585#issuecomment-110523564
> +1, this bug was introduced by me when I worked on rolling upgrade
support, sorry for not catching this during my testing.
It is fine. Rolling upgrades is a big win
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/585#issuecomment-110540302
Only thing we missed is checklist of test, not Parth's mistake. It would be
better while we concern about it.
---
If your project is set up for it, you can reply to
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/585
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
10 matches
Mail list logo
