Github user kishorvpatil closed the pull request at:
https://github.com/apache/storm/pull/597
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/597#issuecomment-160759703
These changes went in as part of #838. So closing the PR and JIRA
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/597#discussion_r43150822
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/NettyUncaughtExceptionHandler.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Softwa
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/597#discussion_r43150246
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/NettyUncaughtExceptionHandler.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache Softwa
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/597#issuecomment-134761846
@harshach Sorry for so long in responding to it. The
`Utils.handleUncaughtException` writes ot STDOUT to avoid further major
exception by attempting to log exception
Github user kishorvpatil commented on a diff in the pull request:
https://github.com/apache/storm/pull/597#discussion_r37927420
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/NettyUncaughtExceptionHandler.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apac
Github user kishorvpatil commented on the pull request:
https://github.com/apache/storm/pull/597#issuecomment-134759973
@eshioji We are catching `Error` not `RunTimeException` which shows more of
a JVM resource issue - hence we do exit from the JVM - its more serious than
just consid
Github user eshioji commented on the pull request:
https://github.com/apache/storm/pull/597#issuecomment-120603640
If the thread is used in `ThreadPoolExecutor` (like the boss & worker
thread pool currently used), `UncaughtExceptionHandler` are not invoked because
`ThreadPoolExecutor`
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/597#discussion_r33100021
--- Diff:
storm-core/src/jvm/backtype/storm/messaging/netty/NettyUncaughtExceptionHandler.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apach
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/597#issuecomment-113995243
@kishorvpatil would it makes sense to log the exception as well? , allows
users to know the cause of jvm exit.
---
If your project is set up for it, you can reply to th
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/597
[STORM-874] Add UncaughtExceptionHandler for netty threads
The netty threads need to handle uncaught exceptions. This would help
ensure that JVM exits if netty threads hit OOM Error while alloc
11 matches
Mail list logo
