[GitHub] storm pull request: In TestHiveBolt make the collector mock slight...

2015-07-16 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/583#issuecomment-122082381 +1 @dossett do you want to file a JIRA for this? It is not a big deal because it is such a small change, but it does impact what type of credit you get for your

[GitHub] storm pull request: In TestHiveBolt make the collector mock slight...

2015-06-21 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/583#issuecomment-113996410 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm pull request: In TestHiveBolt make the collector mock slight...

2015-06-07 Thread dossett
GitHub user dossett opened a pull request: https://github.com/apache/storm/pull/583 In TestHiveBolt make the collector mock slightly more precise The OutputCollector passed to bolt.prepare() can be mocked directly instead of mocking an IOutputCollector used to construct the